Deref mount state var in :stop function in readme?#127
Open
martinklepsch wants to merge 1 commit intotolitius:masterfrom
Open
Deref mount state var in :stop function in readme?#127martinklepsch wants to merge 1 commit intotolitius:masterfrom
martinklepsch wants to merge 1 commit intotolitius:masterfrom
Conversation
Owner
|
a state would only needed to be dereffed "in-cljc-mode" I can see how the "front page" doc may be misleading if ClojureScript is the only env, which is unusual, but probable :) (defstate conn :start (create-conn)
:stop (disconnect conn))
feel free to add it, or I can do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This could be either a question or a documentation fix. In my nodejs/cljs usage of mount I found that I need to deref the var that I define with
defstatein the:stopfunction. Is this correct and the documentation should be updated?Could also a difference between Clojure and ClojureScript maybe?